[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Check calls to printf-like functions (and some fixes) (second version)



Daniel P. Berrange wrote:
This looks like rather dubios legacy code - kill the last arg completely
rather than commenting it out.

Attached - a ridiculously small patch to kill the extra param!

Rich.

--
Emerging Technologies, Red Hat  http://et.redhat.com/~rjones/
64 Baker Street, London, W1U 7DF     Mobile: +44 7866 314 421
 "[Negative numbers] darken the very whole doctrines of the equations
 and make dark of the things which are in their nature excessively
 obvious and simple" (Francis Maseres FRS, mathematician, 1759)
--- src/xml.c.old	2007-03-16 15:42:58.000000000 +0000
+++ src/xml.c	2007-03-16 15:43:19.000000000 +0000
@@ -418,11 +418,11 @@
 
     if (boot_dev) {
         if (xmlStrEqual(boot_dev, BAD_CAST "fd")) {
-            virBufferVSprintf(buf, "(boot a)" /*, (const char *) boot_dev*/);
+            virBufferVSprintf(buf, "(boot a)");
         } else if (xmlStrEqual(boot_dev, BAD_CAST "cdrom")) {
-            virBufferVSprintf(buf, "(boot d)" /*, (const char *) boot_dev*/);
+            virBufferVSprintf(buf, "(boot d)");
         } else if (xmlStrEqual(boot_dev, BAD_CAST "hd")) {
-            virBufferVSprintf(buf, "(boot c)" /*, (const char *) boot_dev*/);
+            virBufferVSprintf(buf, "(boot c)");
         } else {
             /* Any other type of boot dev is unsupported right now */
             virXMLError(conn, VIR_ERR_XML_ERROR, NULL, 0);

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]