[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Fix warn_unused_result when compiling with latest glibc



On Mon, Mar 26, 2007 at 04:22:33PM +0100, Richard W.M. Jones wrote:
> Daniel Veillard wrote:
> >On Mon, Mar 26, 2007 at 03:39:51PM +0100, Richard W.M. Jones wrote:
> >>I'm not sure if this is the right way to solve this, but it is a way.
> >
> >  we should test the return value to check for an error there, the 
> >unfortunate thing is that since we are in a signal handler there isn't
> >much we can do, I suggest to increment a global variable (which could
> >for example be checked if we hit that problem by some other code in
> >the main loop).
> >  Other ideas ?
> 
> How about this patch.  It implements your suggestion.

Looks good to me.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]