[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Enable USB device setting information handlingon virsh.



Hi, Daniel

 Thank you for your comments.
 We never forget this issue.
Please give us a time about this.
(Since JFY(Japan Finalcial Year) is changed when March 31 to April 1)

Thanks
Atsushi SAKAI

 

Daniel Veillard <veillard redhat com> wrote:

> On Thu, Mar 15, 2007 at 05:54:19PM +0900, Masayuki Sunou wrote:
> > Hi Daniel
> > 
> > I contribute some corrected patches. 
> > 
> > 1. strtok() --> strtok_r()
> >    --> Add tok_buf for strtok_r()
> > 2. Correct the first argument of strtok_r()
> > 3. Add a version of XML 
> >    --> So that the format of XML may change in the future 
> > 
> > Signed-off-by: Masayuki Sunou <fj1826dm aa jp fujitsu com>
> 
>   Hi Masayuki,
> 
> I realized I forgot to answer to that patch. Let's not drop the issue !
> The problem is that this new patch still seems to follow the old XML
> of the initial patch while following Dan Berrange last post it looks
> better to integrate the USB specific part in other logical blocs. I 
> don't think adding a version number is the right approach, it's better to
> get the XML set up straight rather than put the burden on long term
> maintainance and at the user level to decode the different ways to
> express the same thing.
> I also don't like strtok_r too much I admit but it's a separate issue :-)
> 
> Daniel
> 
> -- 
> Red Hat Virtualization group http://redhat.com/virtualization/
> Daniel Veillard      | virtualization library  http://libvirt.org/
> veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
> http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/
> 
> --
> Libvir-list mailing list
> Libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]