[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] PATCH: Disable xm_internal.c on newer XenD



On Tue, May 01, 2007 at 01:33:29PM +0100, Daniel P. Berrange wrote:
> The xm_internal.c driver (that processes /etc/xen config files) is only ever
> intended to be used on XenD <= 3.0.3  There are impls of all the methods in
> xend_internal.c that take priority on newer XenD, since the xend driver is
> before it in the stack. The only flaw is that upon failure of one of the
> xend method libvirt will carry on & invoke the xm_internal driver method.
> The attached patch addresses this by completely disabling the xm_internal
> driver on XenD >= 3.0.4

  looks fine, but please fully parenthesize the test,

    thanks,

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]