Re: [Libvir] [PATCH] Allow network drivers to decline to take a connection

[Daniel Veillard <veillard redhat com>]

On Tue, May 01, 2007 at 05:55:16PM +0100, Richard W.M. Jones wrote:
> A couple of problems fixed in the attached patch.
> 
> Firstly the path used to connect to the network driver in non-root mode 
> was wrong.  This may have affected you if you tried to use the 
> test:///default driver as non-root.  I haven't tested this fully, but in 
> any case the path is obviously wrong and needs to be fixed.

  that looks right to me.

> Secondly remote introduces its own network driver, and so we now need to 
> allow network drivers to decline to take a connection (currently they 
> either succeed or give an error - meaning in effect that there can only 
> be one network driver).  The first part of the attached patch allows this.

  Looks fine, I assume no other network driver exist yet so there is only
once to fix for return values.

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/