[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Remote 2/8: Client-server protocol



On Wed, May 02, 2007 at 07:12:36PM +0100, Richard W.M. Jones wrote:
> Richard W.M. Jones wrote:
> >2 Client-server protocol
> >------------------------
> >A qemud/rpcgen_fix.pl
> 
> These are the additional files required to describe the XDR-based 
> protocol for client-server communications, with the homebrew RPC 
> mechanism on top.  The first file is the protocol itself.
> 
> The second file is a Perl script to run after rpcgen which allows the 
> code to compile with -Wall -Werror -fstrict-aliasing, and fixes a 64 bit 
> bug (that fix really should go upstream BTW).

  Hum, we don't require perl to build. Can't that be translated in
python for coherency w.r.t. the existing requires ?
  I would do that if I were able to parse and understand perl, but
I really can't !

> The last two files are the actual rpcgen-generated rpcgen_fix-fixed 
> code.  I put these two files into EXTRA_DIST because I feel that people 
> shouldn't be required to have rpcgen & Perl just to compile libvirt. 
> (These files are arch-independent so there is no need to recompile them 
> unless remote_protocol.x itself changes).

  Hum, so far we tried to not commit generated files...

paphio:~ -> rpm -qf /usr/bin/rpcgen
glibc-common-2.5-12
paphio:~ ->

  but I could see how people on other OSes could have troubles with this.
W.r.t. remote_protocol.x is it the version you posted earlier ?

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]