[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Remote 4/8: Server-side call dispatch



On Sat, May 05, 2007 at 12:30:13PM +0100, Richard W.M. Jones wrote:
> 
> You may notice in remoteDispatchClientRequest that parts are generated 
> automatically, eg. the dispatch switch statement:
> 
>     switch (req.proc) {
> #include "remote_dispatch_proc_switch.h"
> 
>     default:
>         remoteDispatchError (client, &req, "unknown procedure: %d",
>                              req.proc);
>         xdr_destroy (&xdr);
>         return;
>     }
> 
> This is to remove the need to write this tedious and error-prone code by 
> hand.

Good idea.

Not really many comments for these files.

> void
> remoteDispatchClientRequest (struct qemud_server *server ATTRIBUTE_UNUSED,
>                              struct qemud_client *client)
>     ....
>    char *args = NULL, *ret = NULL;

Could those two variables instead be void * - to avoid the need to cast
all assignments to them ?

Finally, with

>     CHECK_CONN;

Is it possible to tweak the macro definition so its use appears as

    CHECK_CONN(client);

So its clear what variable this macro is doing work against.

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]