[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Remote 4/8: Server-side call dispatch



Daniel P. Berrange wrote:
void
remoteDispatchClientRequest (struct qemud_server *server ATTRIBUTE_UNUSED,
                             struct qemud_client *client)
    ....
   char *args = NULL, *ret = NULL;

Could those two variables instead be void * - to avoid the need to cast
all assignments to them ?

Swings & roundabouts ...

The "convention" in XDR code would be for them to be char *, but of course that's because XDR code is pre-ANSI and void * didn't exist :-)

Finally, with

    CHECK_CONN;

Is it possible to tweak the macro definition so its use appears as

    CHECK_CONN(client);

So its clear what variable this macro is doing work against.

Will do.

Rich.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]