[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Device attach/detach on virsh(XML version)



Mark McLoughlin wrote:
On Tue, 2007-05-22 at 15:16 +0100, Richard W.M. Jones wrote:
Richard W.M. Jones wrote:
+    buffer = realloc (buffer, len+1);
+    if (buffer == NULL) goto out_of_memory;

	Note, if realloc() fails, the original buffer isn't freed. So, you want
to make sure you free the original one.

I even kept the oldbuffer around for this reason, but then forgot to free it!

Grrrr ... garbage.collection++

Rich.

--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]