[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] add scheduler API(take 3?)



This patch is based on today's libvirt.
Changes are two points.
1)Sunou's memory leak fixes (I removed free(ipt) from this patch) 
2)Valgrind detected bug fixes 
  in params[i].type & params[i].fields src/virsh.c)

line 467 of this patch.
+    for (i = 0; i < nparams; i++){
+        params[i].type = VIR_DOMAIN_SCHED_FIELD_INIT;
+        strncpy(params[i].field,"              ",15);
+    }

error message detected by valgrind.
==5227== Conditional jump or move depends on uninitialised value(s)
==5227==    at 0x4A066D8: strlen (mc_replace_strmem.c:246)
==5227==    by 0x30E0445B87: vfprintf (in /lib64/libc-2.5.so)
==5227==    by 0x30E04E04D0: __printf_chk (in /lib64/libc-2.5.so)
==5227==    by 0x408EE5: cmdSchedinfo (virsh.c:1035)
==5227==    by 0x408445: vshCommandRun (virsh.c:3056)
==5227==    by 0x408C29: main (virsh.c:3801)


Thanks
Atsushi SAKAI

Attachment: add_scheduler10.patch
Description: Binary data


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]