[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Make "make distcheck" work.



On Wed, Nov 14, 2007 at 07:56:02PM +0100, Jim Meyering wrote:
> Daniel Veillard <veillard redhat com> wrote:
> 
> > On Wed, Nov 14, 2007 at 03:57:10PM +0100, Jim Meyering wrote:
> >> Here's another infrastructure-fixing patch.
> >> I got most of the way to an honest "make distcheck",
> >> but fixing a final failing sub-test wasn't worth the effort,
> >> so I punted and added the top level "distuninstallcheck"
> >> target to make it skip that part.
> ...
> >   okay, lot of this makes sense. The only drawback seems to be loosing
> > the ability to use wildcards to list for example the HTML pages or
> > C examples ...
> >   BTW, have you noticed that docs/examples/Makefile.am is automatically
> > generated, so for that part you will instead need to fix index.py which
> > does the indexing/generation.
> >
> >    okay in principle but the docs/examples/Makefile.am change need to be
> > fixed differently.
> 
> Adjusted patch below.
> I've changed index.py so it generates what you saw before.
> I noticed differences due to use of unsorted glob.glob, so
> made index.py sort that 2-item list.
> 
> Also, it now emits this first line:
> 
> +# -*- buffer-read-only: t -*- vi: set ro:

  okay, makes sense to me, +1

    thanks a lot !

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]