[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH 1/2] KVM network stats



Daniel Veillard wrote:
On Thu, Nov 15, 2007 at 03:53:00PM +0000, Richard W.M. Jones wrote:
Firstly there's a bug in how we parse /proc/net/dev. The format of each interface line turns out to be:

  %6s:...

so in other words network interface names smaller than 6 characters are right justified (padded on the left with spaces).

This isn't a problem for Xen because the shortest interface name (eg. 'vif1.0') is always 6 or more characters long. However it is a problem for QEMU and KVM because we have interface names such as 'vnet0'.

In any case, the following patch fixes this bug.

  Looks fine to me, bugfix, +1

Thanks, both patches applied.

Rich.

--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]