[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH 2/3] Cygwin-specific LDFLAGS and LIBADD



On Thu, Nov 29, 2007 at 04:58:33PM +0000, Richard W.M. Jones wrote:
> Cygwin requires some extra LDFLAGS and LIBADD be passed when linking. 
> Rather than add these extra flags to all invocations, I've created 
> special @CYGWIN_EXTRA_*@ symbols to contain them.
> 
> This is basically copied from libxml2.

  well so this should have got some testing :-)

> Also ordering of *_LIBADD and *_LDFLAGS seems to be important in 
> automake.  Specifically: if libvirt_la_SOURCES comes after 
> libvirt_la_LDFLAGS then automake wasn't able to determine the list of 
> sources (I've no idea why but possibly because libvirt_la_SOURCES is 
> defined in terms of other variables?), so I've reordered these lines.


  Sounds fine,

> Index: src/Makefile.am
> ===================================================================
> RCS file: /data/cvs/libvirt/src/Makefile.am,v
> retrieving revision 1.55
> diff -u -r1.55 Makefile.am
> --- src/Makefile.am	17 Nov 2007 11:17:48 -0000	1.55
> +++ src/Makefile.am	29 Nov 2007 16:43:23 -0000
[...]
> @@ -64,6 +59,13 @@
>  		../qemud/remote_protocol.c ../qemud/remote_protocol.h
>  
>  libvirt_la_SOURCES = $(CLIENT_SOURCES) $(SERVER_SOURCES)
> +libvirt_la_LIBADD = $(LIBXML_LIBS) $(GNUTLS_LIBS) $(LTLIBOBJS) \

  What is LTLIBOBJS ? I don't remember this being added in the previous patch
it shows up in the Makefiles but where does it comes from ?

> +		    @CYGWIN_EXTRA_LIBADD@
> +libvirt_la_LDFLAGS = -Wl,--version-script=$(srcdir)/libvirt_sym.version \
> +                     -version-info @LIBVIRT_VERSION_INFO@ \
> +                    $(COVERAGE_CFLAGS:-f%=-Wc,-f%) \
> +		    @CYGWIN_EXTRA_LDFLAGS@
> +libvirt_la_CFLAGS = $(COVERAGE_CFLAGS)
>  
>  bin_PROGRAMS = virsh

  Just wondering about the above but that looks fine to me.
Windows pythn bindings outside of cygwin can be a bit painful in practice

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]