[Libvir] PATCH: 10/10: fix Xen driver warnings
Daniel Veillard
veillard at redhat.com
Thu Nov 29 19:53:05 UTC 2007
On Thu, Nov 29, 2007 at 05:22:39PM +0000, Daniel P. Berrange wrote:
> If building using --without-xen to disable the Xen driver there
> are a whole bunch of methods in the src/xml.c file which are not
> used. There are littered with #if WITH_XEN to disable small parts
> of the API, but not the whole APIs. This is pointless and results
> in many compile time warnings about unused variables. This patch
> just disables all the Xen specific APIs in xml.c entirely.
>
> src/xml.c | 19 +++++--------------
> src/xml.h | 2 ++
> tests/xml2sexprtest.c | 10 ++++++++++
> 3 files changed, 17 insertions(+), 14 deletions(-)
Well the side effect is that some of the regression tests can't
be run then, we discussed that already, but I'm not against the
patch, just that it reverses a previous decision,
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard at redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
More information about the libvir-list
mailing list