[Libvir] "make check" requires qemu

[Richard W.M. Jones]

Jim Meyering wrote:
> So perhaps libvirt should BuildRequire qemu, too?
> 
> When I ran "make check" on a system without qemu,
> I got lots of failures:
> 
>     ...
>     QEMU XML-2-ARGV Misc ACPI                          ... FAILED
>     libvir: QEMU error : Cannot find QEMU binary /usr/bin/qemu: No such file or directory
>     QEMU XML-2-ARGV Misc No Reboot                     ... FAILED
>     libvir: QEMU error : Cannot find QEMU binary /usr/bin/qemu: No such file or directory
>     QEMU XML-2-ARGV Net User                           ... FAILED
>     FAIL: qemuxml2argvtest
> 
> Here's a patch:
> 
> 2007-10-17  Jim Meyering  <meyering at redhat.com>
> 
> 	* libvirt.spec.in (BuildRequires): Add "qemu".
> 
> Index: libvirt.spec.in
> ===================================================================
> RCS file: /data/cvs/libvirt/libvirt.spec.in,v
> retrieving revision 1.65
> diff -u -p -r1.65 libvirt.spec.in
> --- libvirt.spec.in	12 Oct 2007 19:54:15 -0000	1.65
> +++ libvirt.spec.in	17 Oct 2007 10:11:33 -0000
> @@ -25,6 +25,7 @@ BuildRequires: gnutls-devel
>  BuildRequires: avahi-devel
>  BuildRequires: dnsmasq
>  BuildRequires: bridge-utils
> +BuildRequires: qemu
>  Obsoletes: libvir
>  ExclusiveArch: i386 x86_64 ia64

Committed.  Thanks for your contributions to libvirt!

Rich.

-- 
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20071017/93e74aca/attachment-0001.bin>