[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] PATCH: Remote protocol receive+dispatch cleanup



On Wed, Oct 17, 2007 at 09:26:36PM +0100, Daniel P. Berrange wrote:
> Dating the from time when we had both the QEMU & generic remote protocol
> there are tiny qemud/protocol.{x,c,h} files basically just containing
> one struct for the packet header. This is more or less duplicated in the
> remote protocol & with a few small tweaks can simplify this code. So the
> attached patch removes the protocol.{x,c,h} files. The qemud.c file in
> the 'receive header' branch now merely reads a single 4 byte unsigned
> int to discover the packet length. The rest of the packet is dealt with
> in the 'receive payload' branch. It immediately dispatches to the remote
> program. There is no wire format change here - shouuld just be code cleanup

  Looks good to me, removes duplicated stuff, but I can't say I follow 
completely how the XDR dispatching is happening, maybe Rich can give a more
complete feedback,

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]