[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] PATCH: 4/7 remote protocol & server impl

Daniel P. Berrange wrote:
This patch defines the remote wire protocol for serializing all the storage API calls.
There are 15 new calls for storage pools, and 9 calls for storage volumes. The style
is following that of the network API calls. The serialization of virStorageVolPtr is
slightly more complicated, because it has to have a nested virStoragePoolPtr serialized
alongside it.

As a general comment, I don't think it's worth implementing the remote part of any patch before the local parts have been reviewed and accepted in principle. The remote work should just be a mechanical implementation (except for features which someone depend on remote, which from my brief look this one doesn't). The disadvantage of doing all the remote stuff early is it makes the patch as a whole much harder to change.


Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]