[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] PATCH: Disable automake portability warnings



On Tue, Sep 18, 2007 at 02:49:01AM +0100, Daniel P. Berrange wrote:
> 
> The latest automake has a nasty habit of complaining about use of GNU Make
> features such as wildcards. We use these extensively in the tests/ directory
> since there are so many test datafiles, listing them explicitly is a waste
> of time.

  yeah those warnings were a bit annoying.

> The attached patch passes the -Wno-portability flag to automake to make it
> keep quiet.
> 
> NB, to do this required a bit of a re-working of the automake/autoconf
> initialization stuff. Our current configure script uses AC_INIT and 
> AM_INIT_AUTOMAKE in the so called 'legacy style'. 
> 
> To quote the automake  manual
> 
> [quote]
>      If your `configure.ac' has:
> 
>           AC_INIT([src/foo.c])
>           AM_INIT_AUTOMAKE([mumble], [1.5])
> 
>      you can modernize it as follows:
> 
>           AC_INIT([mumble], [1.5])
>           AC_CONFIG_SRCDIR([src/foo.c])
>           AM_INIT_AUTOMAKE
> [/quote]
> 
> This re-arrangement is valid on any non-jurassic era automake & only impacts
> developers running autogen.sh - not end users running the configure script
> itself.
> 
> The one complication is that the version given to AC_INIT must be a literal,
> but we currently used an environment variable. So m4 black-magic gets around
> this problem. 

  okay +1

> I also killed LIBVIRT_VERSION_EXTRA since it is not referenced anywhere in
> the source tree.

  It can be useful to know whether this was built from CVS and which version
but since we don't use it, fine.

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]