[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] detect path of dnsmasq, brctl

Daniel P. Berrange wrote:
On Thu, Sep 20, 2007 at 06:34:21PM +0100, Richard W.M. Jones wrote:
I have found 3 bugs in libvirtd in the way that it runs the external programs dnsmasq and brctl.

Bug (1) is that it searches the $PATH to find dnsmasq. This is normally OK when libvirtd is launched from start-up scripts, but it's not very helpful if you run libvirtd by hand because likely-as-not your path won't contain /usr/sbin (the normal location of dnsmasq).

Bug (2) is that if libvirtd can't execvp dnsmasq, then it doesn't fail in any obvious way.

Yep, I've never been able to figure out a good answer for that. We
start the network at boot time, so pretty much best we could ever do
is syslog() the problem. Or we could automatically shutdown the virtual
network it dnsmasq fails, but i think that would be even more unpleasant

Bug (3) is that the path to brctl is hard-coded.

This patch fixes bugs (1) & (3), but does not fix bug (2).

This patch looks good to apply.



Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]