[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Allow selection of the NIC model in QEMU/KVM



On Tue, Apr 08, 2008 at 03:16:08PM +0100, Richard W.M. Jones wrote:
> On Tue, Apr 08, 2008 at 02:57:15PM +0100, Daniel P. Berrange wrote:
> > This patch seems incomplete - there's no code to include the <model> tag
> > when dumping the XML.
> 
> Yeah, agreed - forgot about that :-(

Oh, you may also find you need to tweak the test suite too, since that
validates the args for QEMU and don't currently include the model=

> > We should also implement the same for Xen driver really, since that has the
> > choice of ne2k/rtl8139/e1000 too
> 
> I'll have a look.

No need to delay the commit of the KVM impl though of course.

Dan.
-- 
|: Red Hat, Engineering, Boston   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]