[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Enable 'make syntax-check's sc_changelog rule.



"Richard W.M. Jones" <rjones redhat com> wrote:
> On Thu, Apr 10, 2008 at 11:10:05AM +0200, Jim Meyering wrote:
>> I went ahead and wrote the change:
>>
>> 	Enable 'make syntax-check's sc_changelog rule.
>> 	* Makefile.maint (sc_changelog): Adapt to work with legacy
>> 	ChangeLog entry header lines.
>> 	* Makefile.cfg (local-checks-to-skip): Remove sc_changelog.
>
>>  # Each nonempty line must start with a year number, or a TAB.
>> +# Or day-of-week+space.
>> +changelog_entry_header_regexp = \
>> +  ([12][0-9][0-9][0-9]|	.|(Mon|Tue|Wed|Thu|Fri|Sat|Sun) )
>>  sc_changelog:
>> -	@grep -n '^[^12	]' $$(find . -maxdepth 2 -name ChangeLog) &&	\
>> +	@grep -Evn '(^$$|^$(changelog_entry_header_regexp))'		\
>> +	  $$(find . -maxdepth 2 -name ChangeLog) &&			\
>>  	  { echo '$(ME): found unexpected prefix in a ChangeLog' 1>&2;	\
>>  	    exit 1; } || :
>
> Yes, it looks OK to me.
>
> +1
>
> Y3K bug?

Yep.  That was deliberate ;-)
I'd rather be a little more strict.  Who knows... it might even
catch typos with transposed initial digits.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]