[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] MinGW patch



Hi, Rich 

I have 2 questions about MinGW fixes.
(It has already committed, sorry for delaying)

1)src/storage_driver.c patch
  I think storage_driver.c is not compiled on MinGW.
  So It should remove HAVE_PWD_H in src/storage_driver.c
  http://git.et.redhat.com/?p=libvirt.git;a=blobdiff;f=src/storage_driver.c;h=7f1ce0cdc99041ca6fa2ea84aaa9dc5f7764083d;hp=d0e38f66d3051fc2765a67ba932c3b11b2eafdaf;hb=ed8ae56bdc5e5e04ddca6a8839c53b3323783a8f;hpb=26dbf951a3e584b0efe649821ecc9c8b7c956605

2)src/util.c patch
  I think sys/wait.h(waitpid) has not supported on MinGW.
  So I think it should add check (HAVE_SYS_WAIT_H) 
  on waitpid() to avoid compilation warnings.

How do you think?

Thanks
Atsushi SAKAI


"Richard W.M. Jones" <rjones redhat com> wrote:

> I got about 95% of the way towards compiling on MinGW using the MinGW
> cross-compiler from http://mirzam.it.vu.nl/mingw/.  Attached are some
> fairly non-controversial patches which fix some of the problems I
> found.  Build notes follow below.
> 
> Rich.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]