[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH][RFC] libvirt ldoms support



On Fri, Apr 11, 2008 at 05:39:36PM -0500, Eunice Moon wrote:
> Hi Daniel,
> 
> I've added some notes (lines starting with **) to the LDoms XML
> examples to show some semantics for the current XML tags/formats.
> 
> Please see the attached files and let me know if you have any
> questions.

  A couple of remarks at least:
    - the second XML is about communication between libvirt and
      the lDOM infrastructure (daemon i assume), since that's not
      public, not exposed to the user there is no need to change
      any of it. Only the instances passed to
        virDomainCreateLinux/virDomainDefineXML
      and returned by
        virDomainGetXMLDesc/virConnectGetCapabilities
      need to be aligned to match the existing XML format.
    - Looking at the first example, once removed the RPC encapsulation
      it seems it should not be too hard to map to the normal
      XML format, except for a couple of things:
        + the network bridging support definition should probably be moved
	  at least partly to a separated set of API see
	  virNetworkDefineXML/virNetworkCreateXML/virNetworkGetXMLDesc
	  unless I misunderstood the scope of the definitions embedded.
	  http://libvirt.org/formatnetwork.html
	+ a lot of time identifiers are being used in the format,
	  where in libvirt format we would normally use a full path to
	  a device, maybe we can still map the identifiers back to a real
	  device

  Independantly of the XML change, I think there is a well defined set of
changes which were identified already, if you can provide updated patches
for those, then i can probably do the XML mutation part of the patches on top
of them.

Daniel
	  

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]