[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] remove useless tests before xmlFree



On Tue, Apr 29, 2008 at 09:30:39PM +0200, Jim Meyering wrote:
> I've just fixed a bug in my useless-if-detecting script,
> committed in gnulib.  Using that new script with today's
> change adding xmlFree to the list exposed a bunch of useless tests.
> This first change set removes those tests.
> 
> Below it is a separate patch that updates gnulib-related
> files, including that script and vc-list-files.
> I verified that with these changes "make distcheck" passes.
> 
> If no one objects, I'll push these in about 12 hours.
> 
> 	remove useless tests before xmlFree
> 	* src/qemu_conf.c (qemudParseDiskXML, qemudParseInterfaceXML):
> 	(qemudParseInputXML, qemudParseDhcpRangesXML):
> 	* src/remote_internal.c (doRemoteOpen):
> 	* src/storage_conf.c (virStoragePoolDefParseDoc):
> 	* src/xm_internal.c (xenXMParseXMLDisk, xenXMParseXMLVif):
> 	(xenXMParseXMLToConfig, xenXMAttachInterface):
> 	* src/xml.c (virDomainParseXMLDiskDesc, virDomainParseXMLIfDesc):
> 	(virDomainXMLDevID):
> 
> Signed-off-by: Jim Meyering <meyering redhat com>

ACK, please commit .

Dan.
-- 
|: Red Hat, Engineering, Boston   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]