[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] remove useless tests before xmlFree



"Daniel P. Berrange" <berrange redhat com> wrote:
> On Tue, Apr 29, 2008 at 09:44:50PM +0200, Jim Meyering wrote:
>> "Daniel P. Berrange" <berrange redhat com> wrote:
>> > On Tue, Apr 29, 2008 at 09:30:39PM +0200, Jim Meyering wrote:
>> >> I've just fixed a bug in my useless-if-detecting script,
>> >> committed in gnulib.  Using that new script with today's
>> >> change adding xmlFree to the list exposed a bunch of useless tests.
>> >> This first change set removes those tests.
>> >>
>> >> Below it is a separate patch that updates gnulib-related
>> >> files, including that script and vc-list-files.
>> >> I verified that with these changes "make distcheck" passes.
>> >>
>> >> If no one objects, I'll push these in about 12 hours.
>> >>
>> >> 	remove useless tests before xmlFree
>> ...
>> > ACK, please commit .
>>
>> Ok.  I've just done that one.
>> The gnulib one will take a couple more minutes.
>
> I think one of the files from the gnulib refresh got missed from the
> commit
...
> /bin/sh: line 1: ./arpa_inet.in.h: No such file or directory

Thanks for the heads-up.
It did indeed.  I've just committed the fix to add that.
Also, there was a new link error on rawhide, due to
libvirt_proxy's use of the now-gnulib-replaced sprintf function.
Here's the patch:


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]