[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH]: Rework xenLinuxDomainDeviceID to support more devices



Chris Lalancette wrote:
> Jim Meyering wrote:
>> To retain the diagnostic Dan mentioned, you should be able to
>> insert something like this just before the final "else":
>>
>>     else if (disk_re_match("/dev/sd[a-z]([0-9])+$", mod_path, &part)) {
>>
>>> +    else
>>> +        statsErrorFunc (conn, VIR_ERR_INVALID_ARG, __FUNCTION__,
>>> +                        "unsupported path, use xvdN, hdN, or sdN", domid);
> 
> OK, another go, with all of Jim's concerns addressed.  I did something like this
> last point (thanks for the idea Jim), except that I didn't use regex's but basic
> STRPREFIX() to get better error messages.  Dan, is this better?

Committed this version.

Chris Lalancette


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]