[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] update from gnulib



On Thu, Aug 07, 2008 at 11:46:29AM +0200, Jim Meyering wrote:
> I've just checked in a big batch of changes from gnulib.
> Each of those changes has been reviewed by at least two
> people (see bug-gnulib gnu org), and most of them address
> problems also reported on that list, or e.g., on bug-coreutils,
> bug-m4, etc.
> 
> However, I suspect some of them have not yet been exercised
> on RHEL4/5 systems, so test builds there may be interesting.

  Hum, 

on RHEL5 configure/make passes, make tests fails one of the 18 tests:

/u/veillard/libvirt/tests/conftest: No such file or directory
FAIL: test_conf.sh

test:~/libvirt -> file /u/veillard/libvirt/tests/conftest
/u/veillard/libvirt/tests/conftest: ELF 64-bit LSB executable, AMD x86-64, version 1 (SYSV), for GNU/Linux 2.6.9, dynamically linked (uses shared libs), for GNU/Linux 2.6.9, not stripped
test:~/libvirt ->

ldd /u/veillard/libvirt/tests/conftest doesn't show any unresolved lib

I didn't found yet what's going on

for RHEL4 i need the followig patch for it to compile (the function changed
but the signature of the dummy didn't get fixed)

Index: src/bridge.c
===================================================================
RCS file: /data/cvs/libvir/src/bridge.c,v
retrieving revision 1.16
diff -u -p -r1.16 bridge.c
--- src/bridge.c	11 Jul 2008 19:34:11 -0000	1.16
+++ src/bridge.c	7 Aug 2008 09:54:05 -0000
@@ -156,9 +156,7 @@ brAddBridge(brControl *ctl,
 }
 #else
 int brAddBridge (brControl *ctl ATTRIBUTE_UNUSED,
-                 const char *nameOrFmt ATTRIBUTE_UNUSED,
-                 char *name ATTRIBUTE_UNUSED,
-                 int maxlen ATTRIBUTE_UNUSED)
+                 char **name ATTRIBUTE_UNUSED)
 {
     return EINVAL;
 }

I then get 7 of 17 tests failed and 1 not run

 1) virsh list (default)                                              ... FAILED
 2) virsh list (custom)                                               ... OK
 3) virsh nodeinfo (default)                                          ... FAILED
 4) virsh nodeinfo (custom)                                           ... OK

in virshtest 

the same 

./test_conf.sh: line 21: /u/veillard/libvirt/tests
/u/veillard/libvirt/tests/conftest: No such file or directory
FAIL: test_conf.sh

as on RHEL5

and then a bunch of errors on the individual tests, but I guess it's because
there is no hypervisor running or available on that  box :-)

  basically gnulib update seems to not be a problem !

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]