[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH]: file backed usb massstorage  #3



"Daniel P. Berrange" <berrange redhat com> wrote:

> On Fri, Aug 08, 2008 at 02:07:49PM +0200, Jim Meyering wrote:
>> Guido Günther <agx sigxcpu org> wrote:
>> >>From a714b14a13f97b824c288fc40165ef9fe5fbaae0 Mon Sep 17 00:00:00 2001
>> > From: Guido Guenther <agx sigxcpu org>
...
>> Please add a newline and split the long line:
>>
>>   /usr/bin/qemu -S -M pc -m 214 -smp 1 -nographic -monitor pty -no-acpi \
>>     -boot c -hda /dev/HostVG/QEMUGuest1 -usbdevice disk:/tmp/usbdisk.img \
>>     -net none -serial none -parallel none -usb
>
> No, this would break the test case, since its being compared against
> generated data in the format shown by the patch.

Ahh... it looked like something to be executed (and maintained),
rather than merely expected output.  So no need to split long lines.

However, including a trailing newline might be worthwhile
(and adjust the code to emit the matching newline), since some editors
have a hard time modifying or creating a file with no newline at EOF.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]