[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Ensure parted doesn't prompt if labeling disk



On Sun, Aug 10, 2008 at 10:40:30PM -0400, Cole Robinson wrote:
> Trying to 'build' a disk pool uses 'parted mklabel' which can
> prompt for confirmation. Patch adds the '--script' option to
> remove the chance of this happening.

Can you double-check this works on RHEL-5 - IIRC, the --script arg is
a fairly recent addition to parted.

> diff --git a/src/storage_backend_disk.c b/src/storage_backend_disk.c
> index d6548eb..39b857c 100644
> --- a/src/storage_backend_disk.c
> +++ b/src/storage_backend_disk.c
> @@ -406,6 +406,7 @@ virStorageBackendDiskBuildPool(virConnectPtr conn,
>          PARTED,
>          pool->def->source.devices[0].path,
>          "mklabel",
> +        "--script",
>          virStorageBackendDiskPoolFormatToString(conn, pool->def->source.format),
>          NULL,
>      };

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]