[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] fix MinGW compilation(200808)



Hi, Jim and Dan

Thank you for commenting.

I compiled with attached patch successfully.

 src/domain_conf.c    |    1 +
 src/domain_conf.h    |    2 ++
 src/network_conf.c   |    1 +
 src/util.c           |    4 ++--
 src/virsh.c          |    3 +++
 tests/testutilsxen.c |    2 ++
 6 files changed, 11 insertions(+), 2 deletions(-)


Thanks
Atsushi SAKAI




Jim Meyering <jim meyering net> wrote:

> Atsushi SAKAI <sakaia jp fujitsu com> wrote:
> > I am looking around the code about WEXITSTATUS.
> > It seems that following kind of code needs on gnulib.
> > http://kerneltrap.org/mailarchive/git/2008/2/27/1003054
> > What do you think?
> 
> Hi Atsushi,
> 
> Yes, git provides MinGW support, and I see it's compat/mingw.h
> includes this line:
> 
> #define WEXITSTATUS(x) ((x) & 0xff)
> 
> Could it be as easy as adding this?
> 
>   #ifndef WEXITSTATUS
>   # define WEXITSTATUS(x) ((x) & 0xff)
>   #endif
> 
> gnulib provides heavy-weight (different API, and GPL'd) support for
> running subprocesses via its execute module, but it targets more
> than just MinGW.

Attachment: fix_mingw_compile_20080811.patch
Description: Binary data


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]