[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: 3/5: Allow FD for stdout/err to be passed in



On Tue, Aug 19, 2008 at 10:00:37PM +0200, Jim Meyering wrote:
> "Daniel P. Berrange" <berrange redhat com> wrote:
> > The contract for virExec() currently allows the caller to pass in a NULL
> > for stdout/err parameters in which case the child will be connected to
> > /dev/null, or they can pass in a pointer to an int, in which case the
> > child will be connected to a pair of pipes, and the read end of the pipe
> > is returned to the caller.
> >
> > The LXC driver will require a 3rd option - we want to pass in a existing
> > file handler connected to a logfile. So this patch extends the semantics
> > of these two parameters. If the stderr/out params are non-NULL, but are
> > initialized to -1, then a pipe will be allocated. If they are >= 0, then
> > they are assumed to be existing FDs to dup onto the child's stdout/err.
> >
> > This change neccessitated updating all existing callers of virExec to
> > make sure they initialize the parameters to -1 to maintain existing
> > behaviour.
> 
> ACK
> No technical problems...
> so here are some stylistic suggestions

Committed, along with the style changes.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]