[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH] autobuild.sh: Fix minor shell-quoting bugs.



I noticed some minor quoting problems in ovirt's autobuild.sh,
and since part of that code came from here, ...
Here's a patch:

>From 50c37706729b7748dbf92290c6ecf6bc3982f681 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering redhat com>
Date: Thu, 21 Aug 2008 17:55:19 +0200
Subject: [PATCH] autobuild.sh: Fix minor shell-quoting bugs.

* autobuild.sh: Remove unnecessary quotes.
Don't choke on a file name argument containing a space.
Don't misbehave for $AUTOBUILD_INSTALL_ROOT containing
a shell meta-character.
---
 autobuild.sh |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/autobuild.sh b/autobuild.sh
index ce12692..7ae5d1e 100755
--- a/autobuild.sh
+++ b/autobuild.sh
@@ -5,7 +5,7 @@ set -v

 # Make things clean.

-test -n "$1" && RESULTS="$1" || RESULTS="results.log"
+test -n "$1" && RESULTS=$1 || RESULTS=results.log

 test -f Makefile && make -k distclean || :
 rm -rf coverage
@@ -14,7 +14,7 @@ rm -rf coverage
 #mkdir build
 #cd build

-./autogen.sh --prefix=$AUTOBUILD_INSTALL_ROOT \
+./autogen.sh --prefix="$AUTOBUILD_INSTALL_ROOT" \
   --enable-test-coverage \
   --enable-compile-warnings=error \
   --with-openvz \
@@ -25,8 +25,8 @@ make
 make install

 set -o pipefail
-make check 2>&1 | tee $RESULTS
-make syntax-check 2>&1 | tee -a $RESULTS
+make check 2>&1 | tee "$RESULTS"
+make syntax-check 2>&1 | tee -a "$RESULTS"
 test -x /usr/bin/lcov && make cov

 rm -f *.tar.gz
--
1.6.0.90.g436ed


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]