[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Attempt to detect cdrom change failures



On Mon, Aug 25, 2008 at 01:05:03PM -0400, Cole Robinson wrote:
> Cole Robinson wrote:
> > If a 'change' or 'eject' qemu monitor command fails,
> > an error message is printed to the monitor of the
> > form "device {not found, is locked, is not 
> > removable"}. This is really the only indication we
> > have that the command errored out, so scrape the
> > monitor reply for "\ndevice " and fail if it is
> > found.
> > 
> 
> There is an obvious syntax error in the patch (that's
> what I get for changing things last minute and not
> testing)

Seems like a +1 to me.

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]