[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] storage pool discovery



On Wed, Aug 27, 2008 at 03:34:14PM -0400, David Lively wrote:
> On Wed, 2008-08-27 at 17:51 +0100, Daniel P. Berrange wrote:
> > On Mon, Aug 25, 2008 at 10:33:45AM -0400, David Lively wrote:
> > > After making the change I suggested above, it now feels a little strange
> > > because "Pool" is gone from the name.  I'm starting to think
> > > "*Discover[Storage]PoolSources*" is the only good choice.  It's rather
> > > long, but makes it clear we're talking about storage pool sources (as
> > > opposed to "storage sources", which feels a little ambiguous, or
> > > "storage pools" which isn't accurate since they're not (yet) pools).
> > 
> > Discover is a bit of a long word - lets use 'Find' instead, so it makes
> > the API name a little shorter - and no worse than our existing longest
> > API name. In other words:
> > 
> >    virConnectFindStoragePoolSources()
> 
> Sounds good.  The attached patch uses this name (and others consistent
> with it), and should implement all the suggestions from Daniel V and Jim
> M.

Excellant work - I've committed all this to CVS before we change our
minds on naming yet again :-)

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]