[libvirt] [PATCH] introducing <source> <name> (for logical storage pools)

[David Lively]

Hi Jim -
  I've attached a (very) small incremental patch (i.e., to be applied
after the one you've already merged) that addresses a couple things I
noticed missing:
  (a) documents the new <source> <name> element in formatstorage.html.in
  (b) adds --source-name to the (optional) args for virsh pool-define-as
  
  I've also attached a new version of the full patch containing this
change, in case that's easier.

Thanks,
Dave


On Thu, 2008-08-21 at 20:55 +0200, Jim Meyering wrote:
> David Lively <dlively at virtualiron.com> wrote:
> > Oops - that was against an old base.  Sorry.  Here's the new one.
> 
> Good timing.
> I was in the process of replying,
> after having done the merge and add-conn-arg bit.
> 
> > Also fixed a few other issues ...
> 
> ACK.
> I compared the result of my merge/tweaks and your new patch
> and see you fixed everything I saw.  The only difference was
> that when I inserted "conn, " and it pushed past the 80-col
> limit, I split the line:
> 
> diff --git a/src/storage_conf.c b/src/storage_conf.c
> index e49f684..74c3f1e 100644
> --- a/src/storage_conf.c
> +++ b/src/storage_conf.c
> @@ -328,3 +329,4 @@ virStoragePoolDefParseDoc(virConnectPtr conn,
>      if (options->flags & VIR_STORAGE_BACKEND_POOL_SOURCE_NAME) {
> -        ret->source.name = virXPathString(conn, "string(/pool/source/name)", ctxt);
> +        ret->source.name = virXPathString(conn, "string(/pool/source/name)",
> +                                          ctxt);
>          if (ret->source.name == NULL) {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: storage-source-name-incr0.patch
Type: text/x-patch
Size: 3253 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20080829/f0ca5fd3/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: storage-source-name.patch
Type: text/x-patch
Size: 8072 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20080829/f0ca5fd3/attachment-0003.bin>