[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: 11/28: Reduce return points for UML driver



Jim Meyering <jim meyering net> wrote:
> Ron Yorston <rmy tigress co uk> wrote:
>> "Daniel P. Berrange" <berrange redhat com> wrote:
>>> static int umlDomainShutdown(virDomainPtr dom) {
> ...
>>>+    char *info;
> ...
>>>     VIR_FREE(info);
> ...
>> info should be initialised to NULL, otherwise the VIR_FREE will fail.
>> With the umlMonitorCommand if'ed out this is also broken before the
>> patch, which is how I came to notice it.
>>
>> Ron
>
> Thanks for reporting that!
> I'll commit the following shortly:
>
> Mon Nov 30 10:28:21 CET 2008 Jim Meyering <meyering redhat com>
>
>        uml: don't free an uninitialized variable
>        * src/uml_driver.c (umlDomainShutdown): Initialize "info".
>        Patch and bug report from Ron Yorston <rmy tigress co uk>.

Committed.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]