[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: 24/28: Change RPC handler error contract



On Mon, Dec 01, 2008 at 12:16:29AM +0000, Daniel P. Berrange wrote:
> The current RPC handler methods have two possible return codes, -1 and -2,
> both indicate that an error occurred, but one says that the error has
> been serialized onto the outgoing dispatch buffer already, the other
> says that the caller must do serialization. This unneccessarily complex
> and has a number of errors already, so this patch makes the RPC handler
> responsible for all error serialization.

  I tried to have a glance though the code, it's a bit hard but it
seems most of it is kind of similar once the old error routine
is changed everything seems to result from it, including change
in parameters, so +1

Daniel


-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]