[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] Open monitor logs O_APPEND



On Fri, Dec 05, 2008 at 02:20:08PM +0100, Daniel Veillard wrote:
> On Thu, Dec 04, 2008 at 05:44:30PM +0100, Guido Günther wrote:
> > On Thu, Dec 04, 2008 at 01:26:40PM +0000, Daniel P. Berrange wrote:
> > > On Thu, Dec 04, 2008 at 02:11:07PM +0100, Guido G?nther wrote:
> > > > Hi,
> > > > attached patch is from Debian Bug #507553:
> > > > 
> > > > The logfile is opened with O_APPEND (to make logrotate work with
> > > > copytruncate) and without O_TRUNC (to not lose log information e.g. with
> > > > stop and start of a VM).
> > > > 
> > > > Using collectd or munin to monitor VMs creates quiet a bit of qemu
> > > > monitor output so the ability to use logrotate makes a lot of sense to
> > > > me.
> > > 
> > > And is there a corresponding logrotate config file from Debian we
> > > can use ?  If we're going to let log files append, then we need to
> > > ship a logrotate config by default too.
> > I've changed the patch to only use O_APPEND as root so we don't fill up
> > the user's log when running as qemu:///session
> > 
> > > ACK if we add a logrotate config too
> > New version attached. O.k. to apply?
> 
>   Looks fine to me, we will need to update the spec file but that can be
> done later,
Applied now with one minor change: we create the logdir now during "make
install" since logrotate otherwise complains about the missing dir.
Cheers,
 -- Guido


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]