[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH] Fix locking issue in testVolumeLookupByPath



The attached patch fixes a locking issue in the test driver,
specifically testStorageVolumeLookupByPath. We were only unlocking the
pool object if it was running. This fixed a deadlock I was seeing while
adding some new tests to virtinst's test framework.

Thanks,
Cole
diff --git a/src/test.c b/src/test.c
index 257fc8a..defa00f 100644
--- a/src/test.c
+++ b/src/test.c
@@ -2909,8 +2909,8 @@ testStorageVolumeLookupByPath(virConnectPtr conn,
                 virStoragePoolObjUnlock(privconn->pools.objs[i]);
                 break;
             }
-            virStoragePoolObjUnlock(privconn->pools.objs[i]);
         }
+        virStoragePoolObjUnlock(privconn->pools.objs[i]);
     }
     testDriverUnlock(privconn);
 

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]