[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: avoid libvirtd link failure with CFLAGS=-g



"Daniel P. Berrange" <berrange redhat com> wrote:
>> +# This must be added last.
>> +libvirtd_LDADD += ../gnulib/lib/libgnu.la
>> +
>
> Can you mention why this need to be added last in the comment so I don't
> accidentally revert it again in the future.

Sure.
I've just committed this:

diff --git a/qemud/Makefile.am b/qemud/Makefile.am
index 8cb0847..b8dae88 100644
--- a/qemud/Makefile.am
+++ b/qemud/Makefile.am
@@ -93,8 +93,7 @@ libvirtd_LDADD =					\
 	$(LIBXML_LIBS)					\
 	$(GNUTLS_LIBS)					\
 	$(SASL_LIBS)					\
-	$(POLKIT_LIBS)					\
-	../gnulib/lib/libgnu.la
+	$(POLKIT_LIBS)

 if ! WITH_DRIVER_MODULES
 if WITH_QEMU
@@ -244,6 +243,10 @@ uninstall-init:

 endif # DBUS_INIT_SCRIPTS_RED_HAT

+# This must be added last, since functions it provides/replaces
+# are used by nearly every other library.
+libvirtd_LDADD += ../gnulib/lib/libgnu.la
+
 endif # WITH_LIBVIRTD

 CLEANFILES = libvirtd.init
--
1.6.0.4.1044.g77718


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]