[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virConnectGetHostname: return a fully qualified hostname



On Thu, 2008-12-11 at 10:29 +0000, Daniel P. Berrange wrote:
> ACK to the rest of the patch - particularly the removal of all those
> duplicated impls !

I would have liked to have just one impl of virConnectGetHostname that
does the whole gethostname dance, but each driver uses slightly
different ways to report errors, and I didn't feel like getting into
that for this simple change, though it should definitely be simplified.

David



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]