[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] clarify Makefile message about tabbed indentation



On Thu, Dec 11, 2008 at 08:12:07PM +0100, Jim Meyering wrote:
> Dave Allan <dallan redhat com> wrote:
> > I made a few changes to some of the sources, not realizing my editor
> > was using tabs for indentation which caused the build to complain.  I
> > wasn't sure what the error was trying to tell me at first; here's a
> > patch that makes the message clearer (to me at least).
> >
> > Dave
> > diff --git a/Makefile.maint b/Makefile.maint
> > index 10d481b..3b7594d 100644
> > --- a/Makefile.maint
> > +++ b/Makefile.maint
> > @@ -310,7 +310,7 @@ sc_TAB_in_indentation:
> >  	     $$($(VC_LIST_EXCEPT)					\
> >  	        | grep -E '\.[ch](\.in)?$$'				\
> >  	        | grep -v '^gnulib/') &&				\
> > -	  { echo '$(ME): found TAB(s) use for indentation; use spaces'	\
> > +	  { echo '$(ME): found TAB(s) used for indentation in C sources; use spaces'	\
> >  		1>&2; exit 1; } || :
> 
> ACK, but please split that line so it doesn't exceed 80 columns, e.g.,
> 
> 	  { echo '$(ME): found TAB(s) used for indentation in C sources;' \
>               'use spaces' 1>&2; exit 1; } || :

  Okay, fixed accordingly, commited in CVS,

    thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]