[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] remove redundant optname arguments



On Fri, Dec 12, 2008 at 05:45:28PM +0100, Jim Meyering wrote:
> 
> >From a5c76721c22cf51b47059a91317f87a9f47c6868 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <meyering redhat com>
> Date: Tue, 9 Dec 2008 22:22:08 +0100
> Subject: [PATCH] remove redundant optname arguments
> 
> This is the second part of the change mentioned here:
> 
>   http://thread.gmane.org/gmane.comp.emulators.libvirt/10331
> 
> It removes the essentially redundant "optname" parameter
> from each of the vshCommandOptNetworkBy and vshCommandOptDomainBy
> functions as well as the correspond macros (without "By" suffix).
> Now, instead of always passing the optname, "domain", to
> vshCommandOptDomainBy, that function requires that its command
> argument refer to an opts array containing a "domain" option.

  Sounds a step toward consistency and implification so fine.

> This normalization makes one more help-related change:
> it renames the net-start "name" argument to the more
> sensible and consistent "network".

  yes good idea

   +1

  thanks !

Daniel


-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]