[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Remove non-existent symbols from the version script



On Mon, Dec 15, 2008 at 11:59:56AM -0800, john levon sun com wrote:
> # HG changeset patch
> # User john levon sun com
> # Date 1229369745 28800
> # Node ID d3e5c2e138bd794ab711cc2548c45112ba603ea2
> # Parent  56d77e29bf90057791feebfa47506fc0933cd690
> Remove non-existent symbols from the version script
> 
> The Solaris linker rightfully complains if a non-existent symbol is
> referenced. Since these symbols don't exist in the current source, they
> can have no purpose in a version script, so remove them.

ACK, these are all left-overs from APIs we had proposed in patches
and then left out when finally committing to the repository.

An item for someone's todo list...

Create a new 'make check' test which runs 'nm' on the libvirt.so, extracts
the list of exported symbols, compares to those in the version script
and complains if there's any in the version script which aren't exported.
This would make sure we don't accidentally cause regressions for Solaris
in the future.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]