[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Cast callbacks to the correct type



On Mon, Dec 15, 2008 at 11:58:26AM -0800, john levon sun com wrote:
> # HG changeset patch
> # User john levon sun com
> # Date 1229367890 28800
> # Node ID 728f90c86f2cd950463923c80fc57754d6e762eb
> # Parent  6a8e82d7d2e166880fed8d7ad860a3e2e93d62be
> Cast callbacks to the correct type
> 
> Avoid compiler warnings by performing the correct casts.

Actually, the declaration in src/driver.h is the thing that is broken. 
It should be declaring it param as  'virConnectDomainEventCallback cb'
instead of 'void *cb, then we'd avoid the need for casts in libvirt.c, 
or the drivers.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]