[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix statement not reached compiler error



On Mon, Dec 15, 2008 at 11:59:08AM -0800, john levon sun com wrote:
> # HG changeset patch
> # User john levon sun com
> # Date 1229369745 28800
> # Node ID 2bee618a0557131c383b124b2b88bd407b462df4
> # Parent  16ceb6f2e00c4639e97440723e57ec0be6d12cd9
> Fix statement not reached compiler error
> 
> Signed-off-by: John Levon <john levon sun com>

I think I'd prefer if we just replaced the 'return 0' with
'return err', and then just remove the two earlier returns,
keeping the else {} clause.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]