[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Allow storage FS backend to be disabled



On Mon, Dec 15, 2008 at 11:59:46AM -0800, john levon sun com wrote:
> # HG changeset patch
> # User john levon sun com
> # Date 1229369745 28800
> # Node ID 56d77e29bf90057791feebfa47506fc0933cd690
> # Parent  ce24d41d372948cd5440cf17bdb58ce33faffa84
> Allow storage FS backend to be disabled
> 
> It's Linux-specific, and it should be possible to disable it

Yes & no. The storage_backend_fs.c file is actually 3 backends all
in  one file. 

 - A directory based pool
 - A local filesystem based pool
 - A network filesystem based pool

The directory based pool only uses trivial POSIX apis like
open/read/write/close/stat and is intended to be the one
impl that is guarenteed available on all operating systems.
Thus we delibrately don't disable the whole compilation of
this file in the Makefile.am

The latter two pool definitely have linux-specific in them
today, but in theory they could be ported. The WITH_STORAGE_FS
conditional is supposed to be disabling the non-portable Linux
code in the storage_backend_fs.c file, while leaving the portable
directory based pool enabled. Its always possible we've introduced
non-portability / bugs that need fixing. 

What compile errors do you get from the storage_backend_fs.c
on Solaris when you run configure --without-storage-fs ?

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]