[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Avoid GCC extensions



On Mon, Dec 15, 2008 at 11:58:06AM -0800, john levon sun com wrote:
> diff --git a/src/domain_conf.h b/src/domain_conf.h
> --- a/src/domain_conf.h
> +++ b/src/domain_conf.h
> @@ -307,12 +307,13 @@ struct _virDomainHostdevDef {
>                       unsigned slot;
>                       unsigned function;
>                  } pci;
> -            };
> +            } u;
>          } subsys;
AFAIK we're currently not using the pci part of this union since PCI
passthrough isn't implemented yet. So I wonder if should drop this
altogether for the moment?

>          struct {
>              /* TBD: struct capabilities see:
>               * https://www.redhat.com/archives/libvir-list/2008-July/msg00429.html
>               */
> +            int dummy;
>          } caps;
Basically the same here. We can easily add it back when somebody is
working on it.
Cheers,
 -- Guido

>      } source;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]