[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix GCC hard-coding in python/



john levon sun com wrote:
> Fix GCC hard-coding in python/
...
> diff --git a/acinclude.m4 b/acinclude.m4
> --- a/acinclude.m4
> +++ b/acinclude.m4
> @@ -75,6 +75,11 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[
>
>      WARN_CFLAGS="$COMPILER_FLAGS $complCFLAGS"
>      AC_SUBST(WARN_CFLAGS)
> +
> +    COMPILER_FLAGS=
> +    gl_COMPILER_FLAGS(-Wno-redundant-decls)
> +    NO_RDECLS_CFLAGS=$COMPILER_FLAGS
> +    AC_SUBST(NO_RDECLS_CFLAGS)
>  ])
>
> diff --git a/python/Makefile.am b/python/Makefile.am
> --- a/python/Makefile.am
> +++ b/python/Makefile.am
> @@ -35,7 +35,7 @@ python_LTLIBRARIES = libvirtmod.la
>
>  libvirtmod_la_SOURCES = libvir.c types.c libvirt-py.c libvirt-py.h
>  # Python header files contain a redundant decl, hence:
> -libvirtmod_la_CFLAGS = -Wno-redundant-decls
> +libvirtmod_la_CFLAGS = @NO_RDECLS_CFLAGS@

That -Wno-redundant-decls option is no longer necessary, at least
on rawhide.  When I remove it, compiling with "make -C python
CFLAGS='-Wredundant-decls -Werror'" still succeeds.

So how about simply removing it?
That also avoids adding the relatively distant
python/Makefile.am -> acinclude.m4  dependency.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]