[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] don't assume builddir == srcdir

Guido Günther <agx sigxcpu org> wrote:
> Makefile.maint assumes this in some places. This doesn't make the world
> perfect but maybe a bit better?

Um, not really, since a pathological $(abs_srcdir) may contain "; rm -rf /;"

Best to avoid it and use $(srcdir) instead.

Were you able to construct a situation in which this change helped?
I wonder, since in a non-srcdir builds,
GNUmakefile and Makefile.maint don't exist, so it should be impossible
to run their rules without either copying them into the build directory
or using make's -f option.

[copying the files into place, to test this ...]
It looks like if you use VC_LIST's -C option,
then that invalidates the exempted names in the .x-sc* files.

FWIW, I did "make distclean && mkdir .j && cd .j && ./configure".
>From there, none of the Makefile.maint rules are available.

Eventually, I'll probably sync from coreutils/gnulib, where this
file is now named maint.mk.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]